Switch to better maintained go-charset fork (Closes: #134). #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Smirnov <[email protected]>
|
That would be great idea. But I've already did that once, from the google code to rog pepe. How can we find a repository that would be maintained in the long run? |
|
Well, google code is gone and at the moment I suggest we switch to project that is currently best maintained. I doubt you can find guarantees that it will stay like this forever. One simply have to adapt to changes. Let's hope that new go-charset proves itself to be the best. :) |
|
Also worth noticing that nobody can use |
|
I completely removed this dependency in #580. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is merged it would be great to tag new formal release. Thanks.