AVO-619: Remove partially estimated tag from charts #7364
+16
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadeban
force-pushed
the
cadeban/remove-prelim
branch
from
cf907c7
to
820c25e
Compare
cadeban
force-pushed
the
cadeban/remove-prelim
branch
from
e43f818
to
cbf464a
Compare
cadeban
force-pushed
the
cadeban/remove-prelim
branch
from
cbf464a
to
d0af0a2
Compare
VIKTORVAV99
reviewed
Nov 6, 2024
| <EstimationBadge | ||
| text={pillText} | ||
| Icon={ | ||
| estimationMethod === EstimationMethods.TSA ? CircleDashed : TrendingUpDown |
There was a problem hiding this comment.
Could we add the FORECASTS_HIERARCHY method here as well (and other places we use preliminary) since it's also a TSA model enhanced with solar and wind forecasts?
Maybe it should be a follow up PR though.
There was a problem hiding this comment.
Good suggestion - if it's a quick change then I'll include it in this one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AVO-619: Remove partially estimated tag from charts
preliminaryandestimatedbadges from charts except for bar breakdownTODO: Discuss with leadership - does this conflict with our stance on scientific integrity?
Preview
Hourly:
Aggregation:
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.