You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rebuild() method has not been passing the platform to the electron-rebuild.
This means electron-builder has been using the process.platform no matter what platform you specify, which means no cross-platform build if an app includes native modules that include prebuilt binaries.
Combined with the fix for @electron/rebuild at electron/rebuild#1072 I have confirmed that now I can successfully build using electron-builder for ALL platforms using the correct native built binaries.
The `rebuild()` method has not been passing the platform to the electron-rebuild, which meant, electron-rebuild has been using the `process.platform` no matter what platform you specify, which means no cross-platform build if an app includes native modules that include prebuilt binaries.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@mmaietta I tried using 24.5.2 and set npmRebuild at true but it ain't working as previous versions of electron builder. Previously I used electron-builder version=23.6.0. Rebuilding native dependencies and install prebuilt binary are the missing lines in my electron-builder output. Currently this is blocking me to upgrade from 23 to 24.
@willemdjong please create a Issue ticket, tag me, and we can consolidate our convo there. I'll need a minimum reproducible repo of the project to test with as well
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rebuild()method has not been passing the platform to the electron-rebuild.This means electron-builder has been using the
process.platformno matter what platform you specify, which means no cross-platform build if an app includes native modules that include prebuilt binaries.Combined with the fix for
@electron/rebuildat electron/rebuild#1072 I have confirmed that now I can successfully build using electron-builder for ALL platforms using the correct native built binaries.