Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api-review/skip-delay ⏰ label #166

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

itsananderson
Copy link
Member

As we've discussed over the last couple weeks, we want a way to manually skip the default 7 day delay for API Review approval, for API changes that need to land more quickly to address emergent issues (e.g. browser or OS upgrades).

This PR updates Cation to look for a new api-review/skip-delay ⏰ label, and skip the 7 day delay if present.

I'm happy to update the PR with a different label name if anyone has a better suggestion 😄

@itsananderson itsananderson requested review from a team as code owners September 20, 2024 17:34
@erickzhao erickzhao changed the title Add api-review/skip-delay ⏰ label feat: add api-review/skip-delay ⏰ label Sep 20, 2024
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @itsananderson!

@ckerr ckerr merged commit 3bc1115 into electron:main Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants