Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve cloud-based HSM documentation #32

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Conversation

felixrieseberg
Copy link
Member

No description provided.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple copy-editing edits and a few questions!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@erickzhao erickzhao changed the title Improve Cloud-based HSM documentation docs: improve cloud-based HSM documentation Jul 22, 2024
felixrieseberg and others added 2 commits July 23, 2024 10:00
Co-authored-by: David Sanders <[email protected]>
Co-authored-by: Erick Zhao <[email protected]>
Co-authored-by: David Sanders <[email protected]>
README.md Outdated Show resolved Hide resolved
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any context on the content, but I noticed some Markdown syntax issues.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated

Some providers provide drop-in replacements for `signtool.exe`. If that's the case, simply pass the path to that replacement:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: declare language

Suggested change
```
```js

@felixrieseberg felixrieseberg merged commit 6f99fc4 into main Jul 29, 2024
3 checks passed
@felixrieseberg felixrieseberg deleted the felixr-hsm-docs branch July 29, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants