Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE update #109

Merged
merged 3 commits into from
Sep 26, 2024
Merged

LICENSE update #109

merged 3 commits into from
Sep 26, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 26, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner September 26, 2024 11:51
@Velin92 Velin92 requested review from pixlwave and removed request for a team September 26, 2024 11:51
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we should probably also

  • Update the sources of the Inspector - I don't think any of those files have the correct header (my bad)
  • Add the template plist to at least the inspector, possibly also the package itself if that's possible (I don't think it is sadly, but definitely worth investigating).

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (92110af) to head (4629764).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          18       18           
  Lines        1165     1165           
=======================================
  Hits         1125     1125           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 enabled auto-merge (squash) September 26, 2024 12:14
@Velin92 Velin92 enabled auto-merge (squash) September 26, 2024 12:15
@Velin92 Velin92 merged commit 94d93d0 into main Sep 26, 2024
1 check passed
@Velin92 Velin92 deleted the mauroromito/license_update branch September 26, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants