Merge pull request #69 from vector-im/t3chguy-patch-1

element-hq · Sep 4, 2023 · 00812e1 · 00812e1
2 parents 72c0620 + 9bfaf79
commit 00812e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/components/Avatar/Avatar.tsx b/src/components/Avatar/Avatar.tsx
@@ -91,7 +91,6 @@ export const Avatar = forwardRef<
     size,
     style = {},
     onError,
-    title,
     ...props
   },
   ref,
@@ -101,8 +100,8 @@ export const Avatar = forwardRef<
     {
       ref,
       role: "img",
-      title: id,
-      "aria-label": "",
+      // Default the aria-label to id
+      "aria-label": id,
       ...props,
       "data-type": type,
       "data-color": useIdColorHash(id),
@@ -129,7 +128,6 @@ export const Avatar = forwardRef<
           style={style}
           width={size}
           height={size}
-          title={title}
           onError={onError}
         />
       )}

diff --git a/src/components/Avatar/__snapshots__/Avatar.test.tsx.snap b/src/components/Avatar/__snapshots__/Avatar.test.tsx.snap
@@ -3,12 +3,11 @@
 exports[`Avatar > renders the image-less avatar 1`] = `
 <DocumentFragment>
   <span
-    aria-label=""
+    aria-label="@bob:example.org"
     class="_avatar_de1988 _avatar-imageless_de1988"
     data-color="8"
     data-type="round"
     role="img"
-    title="@bob:example.org"
   >
     B
   </span>