Fix a crash when opening v11 rooms. #7635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
requested review from
a team,
alfogrillo and
stefanceriu
and removed request for
a team and
alfogrillo
|
Kudos, SonarCloud Quality Gate passed!
|
stefanceriu
approved these changes
Aug 4, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7635 +/- ##
===========================================
+ Coverage 12.21% 12.36% +0.14%
===========================================
Files 1648 1648
Lines 163667 163665 -2
Branches 67195 67209 +14
===========================================
+ Hits 19996 20236 +240
+ Misses 143026 142764 -262
- Partials 645 665 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creatorwas removed inv11instead favouringsender. This field is currently defined in the spec as required, hence the crash.matrix-org/matrix-spec-proposals#2175
Probably best to hide whitespaces on that diff.
Fixes #7633