Only use the sender when rendering the room creation event. #7640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Room v11 it is possible that the sender could put in a fake creator. Don't allow this to happen.
|
Kudos, SonarCloud Quality Gate passed!
|
pixlwave
requested review from
a team and
Velin92
and removed request for
a team
stefanceriu
approved these changes
Aug 9, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7640 +/- ##
===========================================
+ Coverage 12.21% 12.36% +0.14%
===========================================
Files 1648 1648
Lines 163668 163660 -8
Branches 67195 67206 +11
===========================================
+ Hits 19996 20236 +240
+ Misses 143027 142759 -268
- Partials 645 665 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Room v11 it is possible that the sender could put in a fake creator. Don't allow this to happen.
The changelog already exists for this as #7633