Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage account through MAS if available #7656

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 24, 2023

fixes #7653

Simulator.Screen.Recording.-.iPhone.14.-.2023-08-25.at.12.20.22.mp4

EDIT:
Changed the string "Manage" to" Manage Account"

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.14% 🎉

Comparison is base (83e7229) 12.22% compared to head (cf7efe4) 12.36%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7656      +/-   ##
===========================================
+ Coverage    12.22%   12.36%   +0.14%     
===========================================
  Files         1648     1648              
  Lines       163619   163655      +36     
  Branches     67155    67189      +34     
===========================================
+ Hits         19997    20240     +243     
+ Misses      142976   142749     -227     
- Partials       646      666      +20     
Flag Coverage Δ
uitests 55.04% <ø> (ø)
unittests 6.21% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 marked this pull request as ready for review August 25, 2023 10:23
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Velin92 Velin92 merged commit c2874d6 into develop Aug 25, 2023
9 checks passed
@Velin92 Velin92 deleted the mauroromito/account_management_cell_for_oidc branch August 25, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show link to account management URL when in MSC3824 OIDC aware mode
2 participants