Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead download button image link #7682

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 25, 2023

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@hughns hughns changed the title Fix dead image link Fix dead download button image link Sep 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.37%. Comparing base (344cbec) to head (9ad04aa).
Report is 295 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7682      +/-   ##
===========================================
+ Coverage    12.00%   12.37%   +0.36%     
===========================================
  Files         1650     1650              
  Lines       163849   163849              
  Branches     67228    67255      +27     
===========================================
+ Hits         19668    20273     +605     
+ Misses      143524   142908     -616     
- Partials       657      668      +11     
Flag Coverage Δ
uitests 54.97% <ø> (-0.06%) ⬇️
unittests 6.22% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 39a359d into develop Aug 14, 2024
9 checks passed
@pixlwave pixlwave deleted the hughns/download-button branch August 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants