Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use Jitsi for 1:1 calls with a well-known configuration flag. #7685

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 27, 2023

This PR allows the use of Jitsi for 1:1 calls when the client well-known contains the following:

"io.element.jitsi": {
    "useFor1To1Calls": true
}

It additionally bumps cocoapods to v1.13.0.

Closes #7684
Similar PR in the SDK for Cocoapods: matrix-org/matrix-ios-sdk#1820

Screen.Recording.2023-09-27.at.12.16.58.pm.mov

@pixlwave pixlwave added the Trigger-PR-Build Label to trigger builds for PRs label Sep 27, 2023
@pixlwave pixlwave requested review from a team and aringenbach and removed request for a team September 27, 2023 12:26
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YXkzSz

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dba35a5) 12.35% compared to head (86d6e23) 12.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7685      +/-   ##
===========================================
+ Coverage    12.35%   12.37%   +0.01%     
===========================================
  Files         1650     1650              
  Lines       163846   163854       +8     
  Branches     67253    67258       +5     
===========================================
+ Hits         20250    20274      +24     
+ Misses      142931   142912      -19     
- Partials       665      668       +3     
Flag Coverage Δ
uitests 54.97% <ø> (-0.06%) ⬇️
unittests 6.22% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Configuration/HomeserverConfigurationBuilder.swift 88.88% <100.00%> (+0.29%) ⬆️
...erConfiguration/HomeserverJitsiConfiguration.swift 100.00% <100.00%> (ø)
Riot/Model/WellKnown/VectorWellKnown.swift 100.00% <ø> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave changed the title 7684 Allow the use Jitsi for 1:1 calls with a well-known configuration flag. Sep 27, 2023
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave merged commit f1b6f52 into develop Sep 28, 2023
13 of 14 checks passed
@pixlwave pixlwave deleted the doug/jitsi-1-1 branch September 28, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Label to trigger builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the use of Jitsi for 1:1 calls via a well-known configuration option.
2 participants