Release kMXKAccountAPNSActivityDidChangeNotification observer when de…

[NicolasBuquet]

Remove registered observer kMXKAccountAPNSActivityDidChangeNotification in dealloc of SettingsViewController.

Pull Request Checklist

• I read the contributing guide
• UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
• Accessibility has been taken into account.

• Pull request is based on the develop branch

• Pull request contains a changelog file in ./changelog.d
• You've made a self review of your PR
• Pull request includes screenshots or videos of UI changes
• Pull request includes a sign off

[alfogrillo]

LGTM!

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (94dc313) 11.86% compared to head (d50b82a) 12.37%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7697      +/-   ##
===========================================
+ Coverage    11.86%   12.37%   +0.50%     
===========================================
  Files         1650     1650              
  Lines       163863   163869       +6     
  Branches     67219    67267      +48     
===========================================
+ Hits         19446    20277     +831     
+ Misses      143777   142927     -850     
- Partials       640      665      +25     

Flag	Coverage Δ
uitests	54.97% <ø> (ø)
unittests	6.22% <0.00%> (+0.50%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
Riot/Modules/Settings/SettingsViewController.m	0.00% <0.00%> (ø)

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.