Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mark as unread #7758

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Disable mark as unread #7758

merged 1 commit into from
Feb 21, 2024

Conversation

stefanceriu
Copy link
Member

As part of element-hq/element-meta/issues/2197 and the new version of mark as unread (based on MSC2876) it has been decided that the old (local only, iOS only) legacy implementation be disabled to avoid confusion.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Missing a changelog though

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1dc609b) 12.38% compared to head (c8c6f55) 12.24%.

Files Patch % Lines
...Modules/Common/Recents/Views/RecentTableViewCell.m 0.00% 1 Missing ⚠️
...ntextMenu/ActionProviders/RoomActionProvider.swift 0.00% 1 Missing ⚠️
...ontextMenu/Services/RoomContextActionService.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7758      +/-   ##
===========================================
- Coverage    12.38%   12.24%   -0.15%     
===========================================
  Files         1650     1650              
  Lines       163913   163910       -3     
  Branches     66402    66386      -16     
===========================================
- Hits         20305    20071     -234     
- Misses      142940   143191     +251     
+ Partials       668      648      -20     
Flag Coverage Δ
uitests 55.05% <ø> (+<0.01%) ⬆️
unittests 6.07% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit b39923f into develop Feb 21, 2024
6 of 7 checks passed
@stefanceriu stefanceriu deleted the stefan/disableMarkAsUnread branch February 21, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants