Fix a bug where UIA for cross signing wasn't needed until after checking for it. #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for it. This was due to the parameters not being present in the check, so we no longer check and instead do UIA on failure.
(No other changes are made to the methods).
pixlwave
requested review from
a team and
stefanceriu
and removed request for
a team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check didn't include the parameters that are used for the reset, and as mentioned in the spec, from v1.11 the use of UIA depends on the change being made.
The fix is to simply attempt to reset, and then handle the UIA failure manually after this if it occurs (retrying when the user has completed the authentication).
Unrelated: I updated the SDK so that we pull in matrix-org/matrix-ios-sdk#1885 ready for the next release.
Fixes #7838