Add user_profile_method to upstream SSO provider #3363
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
from
1903904
to
4a62a23
Compare
sandhose
reviewed
Oct 15, 2024
|
|
||
| let env = { | ||
| let mut env = environment(); | ||
| env.add_global("user", minijinja::Value::from_serialize(&id_token)); | ||
| env.add_global("user", userinfo); |
There was a problem hiding this comment.
Just thinking out loud at this point, but it would be nice to have both the userinfo and the idtoken claims in the environment.
I don't know what the right config is to tell whether to fetch userinfo or not for example, but I would set userinfo_claims in the template environment if we fetched it, id_token_claims if we have an id_token and user being somehow a merge of the two?
One stretch goal of this would be for this to work with non-OIDC OAuth 2.0 providers, like GitHub, so we'd need to remove the id_token requirement at some point as well
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
2 times, most recently
from
c59ee5b
to
4a62a23
Compare
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
from
4a62a23
to
d4f4c95
Compare
sandhose
reviewed
Oct 31, 2024
| ADD COLUMN "userinfo_endpoint_override" TEXT; | ||
|
|
||
| ALTER TABLE "upstream_oauth_authorization_sessions" | ||
| ADD COLUMN "userinfo" TEXT; |
There was a problem hiding this comment.
Suggested change
| ADD COLUMN "userinfo" TEXT; | |
| ADD COLUMN "userinfo" JSONB; |
sandhose
reviewed
Oct 31, 2024
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
from
d4f4c95
to
9f3ac54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested for now so I am keeping it as a draft.