-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sliding Sync /sync
endpoint (initial implementation)
#17187
Add Sliding Sync /sync
endpoint (initial implementation)
#17187
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f9e6e53 - Browse repository at this point
Copy the full SHA f9e6e53View commit details
Commits on May 7, 2024
-
Add Sliding Sync
/sync/e2ee
endpoint for To-Device messagesBased on: - MSC3575: Sliding Sync (aka Sync v3): matrix-org/matrix-spec-proposals#3575 - MSC3885: Sliding Sync Extension: To-Device messages: matrix-org/matrix-spec-proposals#3885 - MSC3884: Sliding Sync Extension: E2EE: matrix-org/matrix-spec-proposals#3884
Configuration menu - View commit details
-
Copy full SHA for 1e05a05 - Browse repository at this point
Copy the full SHA 1e05a05View commit details
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5e925f6 - Browse repository at this point
Copy the full SHA 5e925f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69f9143 - Browse repository at this point
Copy the full SHA 69f9143View commit details -
Prefer Sync v2 vs Sliding Sync distinction
We were using the enum just to distinguish /sync v2 vs Sliding Sync /sync/e2ee so we should just make an enum for that instead of trying to glom onto the existing `sync_type` (overloading it).
Configuration menu - View commit details
-
Copy full SHA for d4ff933 - Browse repository at this point
Copy the full SHA d4ff933View commit details -
Configuration menu - View commit details
-
Copy full SHA for 371ec57 - Browse repository at this point
Copy the full SHA 371ec57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06d12e5 - Browse repository at this point
Copy the full SHA 06d12e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8b70ba - Browse repository at this point
Copy the full SHA b8b70baView commit details -
Configuration menu - View commit details
-
Copy full SHA for c60a4f8 - Browse repository at this point
Copy the full SHA c60a4f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10ffae6 - Browse repository at this point
Copy the full SHA 10ffae6View commit details
Commits on May 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6bf4896 - Browse repository at this point
Copy the full SHA 6bf4896View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8871dac - Browse repository at this point
Copy the full SHA 8871dacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0892283 - Browse repository at this point
Copy the full SHA 0892283View commit details -
Configuration menu - View commit details
-
Copy full SHA for adb7e20 - Browse repository at this point
Copy the full SHA adb7e20View commit details -
Configuration menu - View commit details
-
Copy full SHA for f098355 - Browse repository at this point
Copy the full SHA f098355View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b7cfd7 - Browse repository at this point
Copy the full SHA 6b7cfd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9e5379 - Browse repository at this point
Copy the full SHA b9e5379View commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f9c9d44 - Browse repository at this point
Copy the full SHA f9c9d44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 654e8f6 - Browse repository at this point
Copy the full SHA 654e8f6View commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aee594a - Browse repository at this point
Copy the full SHA aee594aView commit details
Commits on May 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2863fba - Browse repository at this point
Copy the full SHA 2863fbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dd0cde - Browse repository at this point
Copy the full SHA 2dd0cdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8256b6 - Browse repository at this point
Copy the full SHA c8256b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee6baba - Browse repository at this point
Copy the full SHA ee6babaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3db068 - Browse repository at this point
Copy the full SHA f3db068View commit details
Commits on May 16, 2024
-
Merge branch 'develop' into madlittlemods/msc3575-sliding-sync-e2ee
Conflicts: synapse/handlers/sync.py tests/handlers/test_sync.py
Configuration menu - View commit details
-
Copy full SHA for 9bdfa16 - Browse repository at this point
Copy the full SHA 9bdfa16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7331401 - Browse repository at this point
Copy the full SHA 7331401View commit details -
Configuration menu - View commit details
-
Copy full SHA for b23abca - Browse repository at this point
Copy the full SHA b23abcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 821a1b3 - Browse repository at this point
Copy the full SHA 821a1b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35ca937 - Browse repository at this point
Copy the full SHA 35ca937View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ad7a8b - Browse repository at this point
Copy the full SHA 4ad7a8bView commit details
Commits on May 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3092ab5 - Browse repository at this point
Copy the full SHA 3092ab5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3539abe - Browse repository at this point
Copy the full SHA 3539abeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f194f9 - Browse repository at this point
Copy the full SHA 5f194f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02cecfa - Browse repository at this point
Copy the full SHA 02cecfaView commit details -
Merge branch 'madlittlemods/msc3575-sliding-sync-e2ee' into madlittle…
…mods/msc3575-sliding-sync-0.0.1
Configuration menu - View commit details
-
Copy full SHA for bfa8c63 - Browse repository at this point
Copy the full SHA bfa8c63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07d84ab - Browse repository at this point
Copy the full SHA 07d84abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dadfe9 - Browse repository at this point
Copy the full SHA 6dadfe9View commit details
Commits on May 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9ffafe7 - Browse repository at this point
Copy the full SHA 9ffafe7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6122ff - Browse repository at this point
Copy the full SHA f6122ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f112e7 - Browse repository at this point
Copy the full SHA 2f112e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2221bb - Browse repository at this point
Copy the full SHA c2221bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 717b160 - Browse repository at this point
Copy the full SHA 717b160View commit details -
Configuration menu - View commit details
-
Copy full SHA for c826550 - Browse repository at this point
Copy the full SHA c826550View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe48188 - Browse repository at this point
Copy the full SHA fe48188View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd355f6 - Browse repository at this point
Copy the full SHA fd355f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd9356a - Browse repository at this point
Copy the full SHA dd9356aView commit details
Commits on May 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 17783c3 - Browse repository at this point
Copy the full SHA 17783c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 343de8f - Browse repository at this point
Copy the full SHA 343de8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b3a5bf - Browse repository at this point
Copy the full SHA 1b3a5bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c82a084 - Browse repository at this point
Copy the full SHA c82a084View commit details -
Merge branch 'develop' into madlittlemods/msc3575-sliding-sync-e2ee
Conflicts: synapse/handlers/sync.py
Configuration menu - View commit details
-
Copy full SHA for 514aba5 - Browse repository at this point
Copy the full SHA 514aba5View commit details -
Update filter to be more precise and avoid more work
- Added `room.account_data` and `room.presence` to avoid extra work in `_generate_sync_entry_for_rooms()` - Added a comment to the top-level `account_data` and `presence` filters that `(This is just here for good measure)` See #17167 (comment)
Configuration menu - View commit details
-
Copy full SHA for 9749795 - Browse repository at this point
Copy the full SHA 9749795View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06ac1da - Browse repository at this point
Copy the full SHA 06ac1daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3da6bc1 - Browse repository at this point
Copy the full SHA 3da6bc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4b41aa - Browse repository at this point
Copy the full SHA d4b41aaView commit details -
Merge branch 'madlittlemods/msc3575-sliding-sync-e2ee' into madlittle…
…mods/msc3575-sliding-sync-0.0.1
Configuration menu - View commit details
-
Copy full SHA for 89db566 - Browse repository at this point
Copy the full SHA 89db566View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7b8743 - Browse repository at this point
Copy the full SHA c7b8743View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7c6476 - Browse repository at this point
Copy the full SHA a7c6476View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13d6146 - Browse repository at this point
Copy the full SHA 13d6146View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7f7ae4 - Browse repository at this point
Copy the full SHA c7f7ae4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c7d7e6 - Browse repository at this point
Copy the full SHA 4c7d7e6View commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6606ac1 - Browse repository at this point
Copy the full SHA 6606ac1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab0b844 - Browse repository at this point
Copy the full SHA ab0b844View commit details -
Configuration menu - View commit details
-
Copy full SHA for a482545 - Browse repository at this point
Copy the full SHA a482545View commit details -
Merge branch 'madlittlemods/msc3575-sliding-sync-e2ee' into madlittle…
…mods/msc3575-sliding-sync-0.0.1
Configuration menu - View commit details
-
Copy full SHA for 04eeee6 - Browse repository at this point
Copy the full SHA 04eeee6View commit details -
Merge branch 'develop' into madlittlemods/msc3575-sliding-sync-0.0.1
Conflicts: synapse/rest/client/sync.py
Configuration menu - View commit details
-
Copy full SHA for 8c3de84 - Browse repository at this point
Copy the full SHA 8c3de84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37af87a - Browse repository at this point
Copy the full SHA 37af87aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a822a05 - Browse repository at this point
Copy the full SHA a822a05View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9fa683 - Browse repository at this point
Copy the full SHA f9fa683View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1bd02d - Browse repository at this point
Copy the full SHA d1bd02dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5b3e77 - Browse repository at this point
Copy the full SHA b5b3e77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65d9b79 - Browse repository at this point
Copy the full SHA 65d9b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc0e2f - Browse repository at this point
Copy the full SHA adc0e2fView commit details
Commits on May 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b12fee5 - Browse repository at this point
Copy the full SHA b12fee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44e9a92 - Browse repository at this point
Copy the full SHA 44e9a92View commit details -
Configuration menu - View commit details
-
Copy full SHA for b632cbb - Browse repository at this point
Copy the full SHA b632cbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for abf139a - Browse repository at this point
Copy the full SHA abf139aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a28569f - Browse repository at this point
Copy the full SHA a28569fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 950fd70 - Browse repository at this point
Copy the full SHA 950fd70View commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8bf5a62 - Browse repository at this point
Copy the full SHA 8bf5a62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34d67fd - Browse repository at this point
Copy the full SHA 34d67fdView commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 49998e0 - Browse repository at this point
Copy the full SHA 49998e0View commit details
Commits on Jun 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 09609cb - Browse repository at this point
Copy the full SHA 09609cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f09313 - Browse repository at this point
Copy the full SHA 8f09313View commit details -
Configuration menu - View commit details
-
Copy full SHA for 803fbbe - Browse repository at this point
Copy the full SHA 803fbbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0c042e - Browse repository at this point
Copy the full SHA a0c042eView commit details -
Use fully-qualified
PersistedEventPosition
when returning membershi……p for user Spawning from #17187
Configuration menu - View commit details
-
Copy full SHA for 271a196 - Browse repository at this point
Copy the full SHA 271a196View commit details -
Fix circular imports when running specific tests
Before: ``` $ SYNAPSE_POSTGRES=1 SYNAPSE_POSTGRES_USER=postgres SYNAPSE_TEST_LOG_LEVEL=INFO poetry run trial tests.replication.storage.test_events [...] Traceback (most recent call last): File "pypoetry/virtualenvs/matrix-synapse-xCtC9ulO-py3.12/lib/python3.12/site-packages/twisted/trial/runner.py", line 711, in loadByName return self.suiteFactory([self.findByName(name, recurse=recurse)]) File "pypoetry/virtualenvs/matrix-synapse-xCtC9ulO-py3.12/lib/python3.12/site-packages/twisted/trial/runner.py", line 474, in findByName obj = reflect.namedModule(searchName) File "pypoetry/virtualenvs/matrix-synapse-xCtC9ulO-py3.12/lib/python3.12/site-packages/twisted/python/reflect.py", line 156, in namedModule topLevel = __import__(name) File "synapse/tests/replication/storage/test_events.py", line 33, in <module> from synapse.handlers.room import RoomEventSource File "synapse/synapse/handlers/room.py", line 74, in <module> from synapse.rest.admin._base import assert_user_is_admin File "synapse/synapse/rest/__init__.py", line 24, in <module> from synapse.rest import admin File "synapse/synapse/rest/admin/__init__.py", line 41, in <module> from synapse.handlers.pagination import PURGE_HISTORY_ACTION_NAME File "synapse/synapse/handlers/pagination.py", line 30, in <module> from synapse.handlers.room import ShutdownRoomParams, ShutdownRoomResponse builtins.ImportError: cannot import name 'ShutdownRoomParams' from partially initialized module 'synapse.handlers.room' (most likely due to a circular import) (synapse/synapse/handlers/room.py) ```
Configuration menu - View commit details
-
Copy full SHA for 4155e18 - Browse repository at this point
Copy the full SHA 4155e18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 939695d - Browse repository at this point
Copy the full SHA 939695dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73c20d9 - Browse repository at this point
Copy the full SHA 73c20d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b41f41 - Browse repository at this point
Copy the full SHA 7b41f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09638ac - Browse repository at this point
Copy the full SHA 09638acView commit details -
Merge branch 'madlittlemods/rooms-for-user-event-pos' into madlittlem…
…ods/msc3575-sliding-sync-0.0.1 Conflicts: synapse/handlers/initial_sync.py tests/replication/storage/test_events.py
Configuration menu - View commit details
-
Copy full SHA for 8dca8f5 - Browse repository at this point
Copy the full SHA 8dca8f5View commit details
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c6ec25 - Browse repository at this point
Copy the full SHA 9c6ec25View commit details -
Properly compare tokens and event positions
Avoid flawed raw stream comparison.
Configuration menu - View commit details
-
Copy full SHA for 1268a54 - Browse repository at this point
Copy the full SHA 1268a54View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4c66b8 - Browse repository at this point
Copy the full SHA e4c66b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35db057 - Browse repository at this point
Copy the full SHA 35db057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3514aa0 - Browse repository at this point
Copy the full SHA 3514aa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 970a0c6 - Browse repository at this point
Copy the full SHA 970a0c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64df6fb - Browse repository at this point
Copy the full SHA 64df6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bb357a - Browse repository at this point
Copy the full SHA 8bb357aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03dd87a - Browse repository at this point
Copy the full SHA 03dd87aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e46b2a - Browse repository at this point
Copy the full SHA 9e46b2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54dbc27 - Browse repository at this point
Copy the full SHA 54dbc27View commit details -
Merge branch 'develop' into madlittlemods/msc3575-sliding-sync-0.0.1
Conflicts: synapse/storage/databases/main/roommember.py
Configuration menu - View commit details
-
Copy full SHA for f6a5905 - Browse repository at this point
Copy the full SHA f6a5905View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07f57a4 - Browse repository at this point
Copy the full SHA 07f57a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3ce27b - Browse repository at this point
Copy the full SHA d3ce27bView commit details -
Switch fixup order to fix edge case with newly_left rooms
Previously, we added back newly_left rooms and our second fixup was removing them. We can just switch the order of the fixups to solve this.
Configuration menu - View commit details
-
Copy full SHA for dfee21a - Browse repository at this point
Copy the full SHA dfee21aView commit details
Commits on Jun 5, 2024
-
Add test with multiple event persisters that fails the previous `get_…
…sync_room_ids_for_user` implementation The new implementation catches the problem with an assert but I think it's possible to make it work as well. ``` SYNAPSE_POSTGRES=1 SYNAPSE_POSTGRES_USER=postgres SYNAPSE_TEST_LOG_LEVEL=INFO poetry run trial tests.handlers.test_sliding_sync.GetSyncRoomIdsForUserEventShardTestCase ```
Configuration menu - View commit details
-
Copy full SHA for 3ce0892 - Browse repository at this point
Copy the full SHA 3ce0892View commit details -
Allow new
get_sync_room_ids_for_user
implementation to work with mu……ltiple event persisters Before, the problem scenario would get caught in one of the assertions because we expect the to_token <= membership_snapshot_token or vice-versa but it's possible the tokens are intertwined and neither is ahead of each other. Especially since the `instance_map` in `membership_snapshot_token` is made up from the `stream_ordering` of membership events at various stream positions and processed on different instances (not current stream positions). We get into trouble when stream positions are lagging between workers and our now/`to_token` doesn't cleanly compare to `membership_snapshot_token`. What we really want to assert is that the `to_token` <= the stream positions at the time we asked for the room membership snapshot. Since `get_rooms_for_local_user_where_membership_is()` doesn't return that information, the closest we can get is to get the stream positions before we ask for the room membership snapshot and consider that good enough to compare against.
Configuration menu - View commit details
-
Copy full SHA for 2864837 - Browse repository at this point
Copy the full SHA 2864837View commit details -
Co-authored-by: Erik Johnston <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2af467d - Browse repository at this point
Copy the full SHA 2af467dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bbe2ed - Browse repository at this point
Copy the full SHA 7bbe2edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fc1b58 - Browse repository at this point
Copy the full SHA 1fc1b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a6cdc6 - Browse repository at this point
Copy the full SHA 6a6cdc6View commit details -
No need to check from/to token relationship
See #17187 (comment) `get_membership_changes_for_user(from_key=xxx, to_key=xxx)` will handle getting out what we need and filter the results based on the tokens (even in cases where the from_key is ahead of the to_key).
Configuration menu - View commit details
-
Copy full SHA for 278ba63 - Browse repository at this point
Copy the full SHA 278ba63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5678307 - Browse repository at this point
Copy the full SHA 5678307View commit details -
Configuration menu - View commit details
-
Copy full SHA for 703cdc9 - Browse repository at this point
Copy the full SHA 703cdc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7d1fc3 - Browse repository at this point
Copy the full SHA c7d1fc3View commit details
Commits on Jun 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0f6646d - Browse repository at this point
Copy the full SHA 0f6646dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0153a6e - Browse repository at this point
Copy the full SHA 0153a6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f10b97 - Browse repository at this point
Copy the full SHA 6f10b97View commit details -
Configuration menu - View commit details
-
Copy full SHA for c89f012 - Browse repository at this point
Copy the full SHA c89f012View commit details