Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation metadata to elementary models and columns #664

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

diorge
Copy link

@diorge diorge commented Feb 20, 2024

Solution to issue elementary-data/elementary#797

Simply adding missing models and columns to YML, with some descriptions.

Added empty descriptions for existing models
under the elementary_tests documentation.
Added empty descriptions for existing models
under the alerts_views documentation.
Added empty descriptions for existing models
under the run_results documentation.
@haritamar
Copy link
Collaborator

HI @diorge !
Thanks for opening this PR and sorry about the delay.

I'm not sure if it is still relevant but in case it is - it seems that tests are currently failing so please do the following:

  1. Ensure the integration tests pass on your warehouse (please see the contribution guide regarding how to run them locally.
  2. The pre-commit step also seems to fail on the YAML formatting - running this in the root dir should help:
pip install -r dev-requirements.txt
pre-commit run --all-files

Thanks,
Itamar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants