Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trino temp tables cleanup #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndrluis
Copy link

@ndrluis ndrluis commented Jul 8, 2024

No description provided.

@ofek1weiss
Copy link
Contributor

ofek1weiss commented Aug 7, 2024

@ndrluis putting it here as well
It seems that this code does not work: https://github.com/elementary-data/dbt-data-reliability/actions/runs/10268957700/job/28413257114?pr=744#step:14:1468
'dbt.context.providers.RuntimeDatabaseWrapper object' has no attribute 'clean_up_table'

Currently for some reason we have some temp test tables and dbt_models__tmp_
@ndrluis
Copy link
Author

ndrluis commented Aug 7, 2024

Sorry @ofek1weiss, I misunderstood the problem. I have now made the correct fix, but we need to wait for this fix from dbt-trino

@ndrluis
Copy link
Author

ndrluis commented Aug 12, 2024

I was informed that the correct macro exists in the dbt-utils-trino, so to make this work properly, we need to have this package. @ofek1weiss, how can we use this library, or would it be better for us to copy the macro from the library and include it here to avoid requiring all users to install a specific trino package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants