Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional --hours-back for edr monitor #1549

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

miktros
Copy link

@miktros miktros commented Jun 6, 2024

Add optional --hours-back for edr monitor to specify how many hours back should edr monitor look for pending alerts.

Fixes: #1548

@ellakz
Copy link
Contributor

ellakz commented Jun 17, 2024

Hi @miktros
I'm not sure how this PR solves the issue in question.
Commented on the issue as well but I believe this will not solve your problem.
If you could shed some light on it I would be happy to review.
Thanks!

@miktros
Copy link
Author

miktros commented Jun 18, 2024

By splitting data into 1-hour time buckets in volume.anomalies tests, we were hoping to be able to run dbt test and then edr monitor every hour so that alert is emitted only for a test with row count in the most recent 1-hour time bucket that is lower than past 21 day average (time bucket failure). We use the "hours-back" option, edr monitor --hours-back 1, to achieve the alerting behavior as described above. With the "days-back" option, alert is emitted each time edr monitor is run when there is a time bucket failure any time during the day, even though the most recent time bucket has no failure. In short, we want per hour alert notification that reflects failure condition of the most recent hour.

@mstfkmlbsbdk2023
Copy link

mstfkmlbsbdk2023 commented Jul 9, 2024

If I don't add any parameter as --hours-back. It takes 1 by default. Is this true or is there any configuration that will change this?

Here is the command how to run edr monitor: edr monitor --teams-webhook<> --group-by table

Screenshot 2024-07-09 at 09 24 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --hours-back CLI option for edr monitor
4 participants