Add databricks support #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review and suggest edits! I'm willing to work on this PR to provide databricks support. |
elongl
reviewed
Feb 29, 2024
| @@ -32,3 +32,8 @@ | |||
| {% set database = target.project %} | |||
| {{ return(database) }} | |||
| {% endmacro %} | |||
|
|
|||
| {% macro databricks__target_database() %} | |||
| {% set database = target.schema %} | |||
There was a problem hiding this comment.
I think host is more closely related to database.
There was a problem hiding this comment.
We've implemented it like this on the dbt package.
There was a problem hiding this comment.
Thanks @elongl for the response.
Does that mean we have to open PR on elementary-data/dbt-data-reliability repository as well to complement changes in elementary-action repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.