Introduce a pan backend for touchscreen gestures #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
force-pushed
the
leolost/use-gesture-pan-backend
branch
2 times, most recently
from
3ea71e2 to
9721f90
Compare
The grab should always be on the actor that was last pushed modal. Clutter keeps a stack of grabs internally so we just can grab every actor.
Add information about whether a gesture will be handled. This might be used to determine whether events are supposed to be consumed. Add information about the origin of a gesture. This might be used to determine whether a gesture should be handled (e.g. only allow swipe from screen edge). Add common GestureBackend interface that all backends have to implement. Add a on_gesture_handled signal to the GestureTracker which runs if and only if true was returned in on_gesture_detected. Before it is emitted prepare_gesture_handling will be called on the backend. This will be needed for the upcoming PanBackend to avoid conflicts in event consuming. Add a utility get_action to the GestureSettings that gets the corresponding action for a gesture. This allows to remove some duplicated code.
leolost2605
force-pushed
the
leolost/use-gesture-pan-backend
branch
from
9721f90 to
d687cf5
Compare
leolost2605
force-pushed
the
leolost/use-gesture-pan-backend
branch
from
d687cf5 to
483f373
Compare
|
This should be ready for testing/review now |
leolost2605
force-pushed
the
leolost/use-gesture-pan-backend
branch
from
483f373 to
5455727
Compare
leolost2605
force-pushed
the
leolost/use-gesture-pan-backend
branch
from
5455727 to
d5ffdff
Compare
This was referenced Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows exact finger tracking for touchscreen devices. Fixes #1272
Fixes #1801
In the long term with some coming mutter changes it will handle all gestures (touchpad as well) in order to remove the need of touchegg which currently only works because of xwayland.
This will also allow us to have much more precise gestures: e.g. swipe up from the bottom to reveal the dock one to one will be trivial to implement (PR incoming). It can also be used to do swipe in from corners to use hotcorners on touchscreen (another PR incoming :) ).
TODO:
meta_wayland_pointer_set_focus: assertion 'meta_cursor_tracker_get_pointer_visible (cursor_tracker) || clutter_seat_is_unfocus_inhibited (clutter_seat) || surface == NULL' failedFor easier review see the individual commits and also their message for details about some changes.
Rebase merge