Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultitaskingView: Allow workspace switch animation to be interrupted #2161

Merged
merged 19 commits into from
Jan 25, 2025

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Dec 11, 2024

First step towards #1202

Remaining are multitasking view open and close and while on the desktop workspace switch but those require the cancelling fixes and are left to follow up PRs.

TODO:

  • Some calculation corrections

@leolost2605 leolost2605 requested a review from a team December 11, 2024 23:05
@leolost2605 leolost2605 changed the title MultitaskingView: Allow workspace switch gesture to be interrupted MultitaskingView: Allow workspace switch animation to be interrupted Dec 11, 2024
@leolost2605 leolost2605 mentioned this pull request Dec 15, 2024
15 tasks
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is bugged after merging #2164 :/

@leolost2605
Copy link
Member Author

@lenemter can you describe what happens? It seems to work fine for me :/

@lenemter
Copy link
Member

This bug happens when you interrupt workspace switch animation while switching to the last workspace

2024-12-20.16-44-59.mp4

@leolost2605 leolost2605 marked this pull request as draft December 20, 2024 20:48
@leolost2605 leolost2605 marked this pull request as ready for review January 25, 2025 14:38
@leolost2605
Copy link
Member Author

This should be ready now.
Cancelling is now also much more predictably. We cancel if

  • We haven't moved far enough and our velocity is to low
  • We are going backwards with enough velocity

This fixes some unintuitive behavior like when switching to a new workspace and you're already there but you decide to go back and swipe fast backwards it won't cancel.

@leolost2605 leolost2605 requested review from a team and lenemter January 25, 2025 14:41
@leolost2605
Copy link
Member Author

I just realized this somehow cancels multitasking view open/close even though it shouldn't...
I'll look into it :)

@leolost2605
Copy link
Member Author

Ok it's fixed now so ready again :)

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird with touchegg backend but there's nothing we can do with it. Looking forward using this with touchpad backend

@lenemter lenemter merged commit de8752f into main Jan 25, 2025
5 checks passed
@lenemter lenemter deleted the leolost/interruptible-workspace-switch-mtv branch January 25, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants