GesturePropertyTransition: Only call done_callback if the transition finished #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transition might be interrupted by the clutter actor being destroyed leading to the callback being called which as a result might want to destroy the actor again leading to a bail out by clutter (this was the case if the nudge animation was ongoing while kill_switch_workspace was called)
Since it shouldn't be used for setting state anyway (because of how we'd like to move to interruptible gestures) which was also clarified in a comment, this should actually be the correct behavior (we don't want to cleanup any animation stuff if we're animating anew anyways).
Fixes #2145