Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting langs #183

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add sorting langs #183

wants to merge 4 commits into from

Conversation

awissu
Copy link
Contributor

@awissu awissu commented Nov 29, 2021

Adds translations sorting for inactive users .

@jeremypw
Copy link
Collaborator

jeremypw commented Nov 29, 2021

This PR seems to have a convoluted commit history. I know this will be squashed, but you should try to make a new branch from a freshly synced master branch. Does it make a difference if the region is inserted at position 1 instead of at position 0?

@awissu
Copy link
Contributor Author

awissu commented Nov 30, 2021

Does it make a difference if the region is inserted at position 1 instead of at position 0?

(1, Gtk.SortType.ASCENDING); -> sort in alphabetical order

(out iter, 1); -> auto region selection in alphabetical order

For example (lang select -> region autoselect):

English -> Australian;
French -> Belgium
German -> Austria;
Russian -> Russian Federation;
Spanish -> Argentina;

instead of:

English -> Zimbabwe;
French -> Luxembourg;
German -> Luxembourg;
Russian -> Ukraine;
Spanish -> Venezuela;

@jeremypw
Copy link
Collaborator

I'll try it out, but I do not see how the position at which the row is initially inserted will have an effect when the list will be sorted anyway. To be honest it might be simpler to implement this with GLib.ListStore. Gtk.ListStore seems overkill for a store containing a couple of strings (?)

@jeremypw
Copy link
Collaborator

I just tried compiling your branch and changed the insert position back to 0. As I suspected, the region combobox is still sorted from A to Z.

@awissu
Copy link
Contributor Author

awissu commented Nov 30, 2021

You value the other person time?
I gave you a concrete example.

@awissu
Copy link
Contributor Author

awissu commented Nov 30, 2021

A careful look at auto region selection.

Before:

Peek 2021-11-30 23-34

After:

Peek 2021-11-30 23-36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants