Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(setup-elementor-env): init #10

Merged
merged 33 commits into from
Jul 30, 2024
Merged

feat(setup-elementor-env): init #10

merged 33 commits into from
Jul 30, 2024

Conversation

Nevoss
Copy link
Member

@Nevoss Nevoss commented Jul 25, 2024

No description provided.

.github/workflows/test-actions.yml Show resolved Hide resolved
.github/workflows/test-actions.yml Show resolved Hide resolved
actions/setup-elementor-env/action.yml Outdated Show resolved Hide resolved
actions/setup-elementor-env/action.yml Outdated Show resolved Hide resolved
actions/setup-elementor-env/action.yml Outdated Show resolved Hide resolved
actions/setup-elementor-env/main.ts Outdated Show resolved Hide resolved
actions/setup-wp-env/action.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
npx @github/local-action run "./actions/$1" index.ts "./actions/$1/.env"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need to be here instead of inlined in the package json?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, it does not work

tsup.config.ts Outdated Show resolved Hide resolved
@@ -54,7 +54,7 @@ export async function run() {
'deactivate',
experiments.off.join(','),
],
error: 'Failed to deactivate experiments',
error: `Failed to deactivate experiments: : ${experiments.on.join(', ')}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
error: `Failed to deactivate experiments: : ${experiments.on.join(', ')}`,
error: `Failed to deactivate experiments: ${experiments.on.join(', ')}`,

@Nevoss Nevoss merged commit 1d11a6c into elementor:master Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants