Skip to content

Commit

Permalink
TMZ-61 addressing CR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mserino committed Oct 22, 2024
1 parent d192d16 commit 7d9e7df
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions modules/template-parts/classes/render/widget-footer-render.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function render(): void {
'class' => $layout_classnames,
] );
?>
<div <?php echo $this->widget->get_render_attribute_string( 'layout' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<div <?php echo $this->widget->print_render_attribute_string( 'layout' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<div class="ehp-footer__row">
<?php
$this->render_side_content();
Expand Down Expand Up @@ -78,11 +78,11 @@ public function render_site_link(): void {
$this->widget->add_link_attributes( 'site-link', $site_link );
}
?>
<a <?php echo $this->widget->get_render_attribute_string( 'site-link' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<a <?php echo $this->widget->print_render_attribute_string( 'site-link' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<?php if ( $site_logo_image ) { ?>
<?php Group_Control_Image_Size::print_attachment_image_html( $this->settings, 'site_logo_image' ); ?>
<?php } else {
$site_title_output = sprintf( '<%1$s %2$s %3$s>%4$s</%1$s>', Utils::validate_html_tag( $site_title_tag ), $this->widget->get_render_attribute_string( 'heading' ), 'class="ehp-footer__site-title"', esc_html( $site_title_text ) );
$site_title_output = sprintf( '<%1$s %2$s %3$s>%4$s</%1$s>', Utils::validate_html_tag( $site_title_tag ), $this->widget->print_render_attribute_string( 'heading' ), 'class="ehp-footer__site-title"', esc_html( $site_title_text ) );
// Escaped above
Utils::print_unescaped_internal_string( $site_title_output );
} ?>
Expand All @@ -103,12 +103,12 @@ public function render_social_icons(): void {
'class' => $footer_icons_classnames,
] );
?>
<div <?php echo $this->widget->get_render_attribute_string( 'icons' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<div <?php echo $this->widget->print_render_attribute_string( 'icons' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<?php
foreach ( $icons as $key => $icon ) {
$link = $icon['footer_icon_link'];
$text = $icon['footer_icon_text'];
$icon = $icon['footer_selected_icon'];
$selected_icon = $icon['footer_selected_icon'];

$icon_classnames = 'ehp-footer__social-icon';

Expand All @@ -125,9 +125,9 @@ public function render_social_icons(): void {
?>

<?php if ( ! empty( $text ) ) : ?>
<a <?php echo $this->widget->get_render_attribute_string( 'icon-' . $key ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<?php if ( ! empty( $icon['value'] ) ) : ?>
<?php Icons_Manager::render_icon( $icon, [ 'aria-hidden' => 'true' ] ); ?>
<a <?php echo $this->widget->print_render_attribute_string( 'icon-' . $key ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<?php if ( ! empty( $selected_icon['value'] ) ) : ?>
<?php Icons_Manager::render_icon( $selected_icon, [ 'aria-hidden' => 'true' ] ); ?>
<?php endif; ?>
</a>
<?php endif; ?>
Expand Down Expand Up @@ -206,7 +206,7 @@ public function render_contact(): void {
] );
?>
<div class="ehp-footer__contact-container">
<div <?php echo $this->widget->get_render_attribute_string( 'contact' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<div <?php echo $this->widget->print_render_attribute_string( 'contact' ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>>
<?php if ( $has_contact ) {
$contact_output = sprintf( '<%1$s %2$s>%3$s</%1$s>', Utils::validate_html_tag( $contact_tag ), 'class="ehp-footer__contact-heading"', esc_html( $contact_text ) );
// Escaped above
Expand Down

0 comments on commit 7d9e7df

Please sign in to comment.