Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Advanced" tab is missing when editing Form-lite widget [TMZ-245][TMZ-248] #133

Merged
merged 6 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/forms/assets/js/frontend/handlers/form-sender.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,13 @@ export default elementorModules.frontend.handlers.Base.extend( {
.find( '#form-field-' + key )
.parent()
.addClass( 'elementor-error' )
.append( '<span class="elementor-message elementor-message-danger elementor-help-inline elementor-form-help-inline" role="alert">' + title + '</span>' )
.append( '<span class="elementor-message elementor-message-danger elementor-help-inline elementor-form-help-inline" role="alert"></span>' ).text( title )
.find( ':input' ).attr( 'aria-invalid', 'true' );
} );

$form.trigger( 'error' );
}
$form.append( '<div class="elementor-message elementor-message-danger" role="alert">' + response.data.message + '</div>' );
$form.append( '<div class="elementor-message elementor-message-danger" role="alert"></div>' ).text( response.data.message );
} else {
$form.trigger( 'submit_success', response.data );

Expand All @@ -109,15 +109,15 @@ export default elementorModules.frontend.handlers.Base.extend( {
}

if ( 'undefined' !== typeof response.data.message && '' !== response.data.message ) {
$form.append( '<div class="' + successClass + '" role="alert">' + response.data.message + '</div>' );
$form.append( '<div class="' + successClass + '" role="alert"></div>' ).text( response.data.message );
}
}
},

onError( xhr, desc ) {
const $form = this.elements.$form;

$form.append( '<div class="elementor-message elementor-message-danger" role="alert">' + desc + '</div>' );
$form.append( '<div class="elementor-message elementor-message-danger" role="alert"></div>' ).text( desc );

this.elements.$submitButton
.html( this.elements.$submitButton.text() )
Expand Down
4 changes: 1 addition & 3 deletions modules/forms/classes/render/widget-form-render.php
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
<?php

namespace HelloPlus\Modules\Forms\Classes\Render;

if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}

use HelloPlus\Modules\Forms\Widgets\Form;

use HelloPlus\Includes\Utils;

use Elementor\Icons_Manager;
use Elementor\Utils as Elementor_Utils;

class Widget_Form_Render {
protected Form $widget;
protected array $settings;

public function __construct( Form $widget ) {
$this->widget = $widget;
Expand Down
4 changes: 2 additions & 2 deletions modules/forms/module.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function get_assets_base_url(): string {
* @return void
*/
public function register_styles() {
wp_enqueue_style(
wp_register_style(
'helloplus-forms',
HELLOPLUS_STYLE_URL . 'helloplus-forms.css',
[ 'elementor-frontend' ],
Expand Down Expand Up @@ -98,7 +98,7 @@ public function enqueue_editor_scripts() {
}

public function register_scripts() {
wp_enqueue_script(
wp_register_script(
'helloplus-forms-editor-fe',
HELLOPLUS_SCRIPTS_URL . 'helloplus-forms-editor-fe.js',
[ 'elementor-common', 'elementor-frontend-modules', 'elementor-frontend' ],
Expand Down
2 changes: 1 addition & 1 deletion modules/template-parts/assets/js/editor/module.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default class TemplatesModule extends elementorModules.editor.utils.Modul
}

resetCommonControls( commonControls, widgetType ) {
if ( widgetType.startsWith( 'ehp-' ) ) {
if ( [ 'ehp-footer', 'ehp-header' ].includes( widgetType ) ) {
return null;
}

Expand Down
Loading