tweak register & enqueue and some code cleanup [TMZ-61] #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…title # Conflicts: # modules/template-parts/classes/render/widget-header-render.php # modules/template-parts/scss/breakpoints.scss # modules/template-parts/scss/variables.scss # modules/template-parts/widgets/header.php
…title # Conflicts: # modules/template-parts/scss/hello-plus-header.scss
use wp native function for site logo / title/ url
# Conflicts: # modules/template-parts/assets/scss/hello-plus-header.scss # modules/template-parts/classes/render/widget-header-render.php # modules/template-parts/widgets/header.php
# Conflicts: # modules/template-parts/module.php # webpack.config.js
mserino
reviewed
Oct 23, 2024
modules/template-parts/module.php
Outdated
| @@ -86,7 +93,9 @@ public static function is_active(): bool { | |||
| */ | |||
| protected function register_hooks(): void { | |||
| parent::register_hooks(); | |||
| add_action( 'wp_enqueue_scripts', [ $this, 'enqueue' ] ); | |||
| // add_action( 'wp_enqueue_scripts', [ $this, 'enqueue' ] ); | |||
There was a problem hiding this comment.
@nuritsha can we remove this since it's commented out?
modules/template-parts/module.php
Outdated
| wp_enqueue_style( 'hello-plus-header' ); | ||
| wp_enqueue_style( 'hello-plus-footer' ); | ||
| wp_enqueue_script( 'hello-plus-header' ); | ||
| } |
There was a problem hiding this comment.
Adding space between function
mserino
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.