TMZ-74 Header 1st round #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuritsha
requested changes
Nov 11, 2024
| @@ -17,7 +17,9 @@ | |||
| use HelloPlus\Includes\Utils as Theme_Utils; | |||
|
|
|||
| use HelloPlus\Modules\TemplateParts\Classes\{ | |||
| Render\Widget_Footer_Render | |||
| Render\Widget_Footer_Render, | |||
| Traits\Shared_Header_Traits, | |||
| @@ -65,7 +67,6 @@ protected function render(): void { | |||
| protected function register_controls(): void { | |||
| $this->add_content_section(); | |||
| $this->add_style_section(); | |||
| $this->add_advanced_tab(); | |||
There was a problem hiding this comment.
as discussed, we do need the custom advanced tab
Comment on lines
80
to
82
| protected function add_advanced_tab(): void { | ||
| $this->add_advanced_behavior_section(); | ||
| parent::add_advanced_tab(); |
There was a problem hiding this comment.
I suggest we tweak the original add_advanced_tab method in the base class, maybe something like this:
protected function add_advanced_tab(): void {
$advanced_tab_id = Controls_Manager::TAB_ADVANCED;
Controls_Manager::add_tab(
$advanced_tab_id,
esc_html__( 'Advanced', 'hello-plus' )
);
$this->add_basic_css_controls_section();
$this->add_custom_advanced_sections(); // new method, base class implementation will be empty, and the Ehp_header will use it to print the `behavior` section
$elementor_plugin = Theme_Utils::elementor();
$elementor_plugin->controls_manager->add_custom_css_controls( $this, $advanced_tab_id );
$elementor_plugin->controls_manager->add_custom_attributes_controls( $this, $advanced_tab_id );
}
nuritsha
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://elementor.atlassian.net/browse/TMZ-74