Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tls1.2 and json conversion should use AsHashtable #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpenner-gbs
Copy link

PowerShell doesn't always enable newer versions of TLS like TLS 1.2. Most WIndows Servers need it explicitly enabled, otherwise they attempt to only use TLS 1.1 which has been deprecated for awhile.

Some JSON responses from Eleos may have multiple mixed-case keys that cannot be converted into case-insensitive Dictionary, which is the default ConvertFrom-Json setting. Using -AsHasthtable gets around this.

@pnc
Copy link
Member

pnc commented Jun 6, 2024

Thanks @jpenner-gbs ! We have intentionally avoided forcing 1.2 since it precludes (AFAICT from Microsoft's docs) TLSv1.3 support and guarantees everyone will have to do this again in a few years to support that. We're encouraging everyone to adjust registry settings as needed, which matches Microsoft's guidance.

The hashtable thing is a good catch, we'll split that change out and try to get it merged. Thanks for putting the changset together.

@jpenner-gbs
Copy link
Author

Good call on not forcing 1.2. If you've got a link on the registry keys I'd appreciate it... the registry keys we've tried on every client systems haven't worked.

@pnc
Copy link
Member

pnc commented Jun 6, 2024

We've been linking people to Microsoft's docs at https://learn.microsoft.com/en-us/mem/configmgr/core/plan-design/security/enable-tls-1-2-client, but results have been mixed, as you say.

We don't have a single Windows license in the organization, so unfortunately our testing is limited to the CI on this project, which uses a new enough version of Windows Server the defaults are already good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants