Skip to content

Commit

Permalink
📝 Adapt set-env deprecation for example
Browse files Browse the repository at this point in the history 
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
  • Loading branch information
@elgohr
elgohr authored Nov 8, 2020
1 parent b1253b2 commit e6b13fe
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -225,16 +225,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Get release version
id: get_version
run: echo ::set-env name=RELEASE_VERSION::$(echo ${GITHUB_REF:10})
- name: Publish to Registry
pre: echo ::save-state name=RELEASE_VERSION::$(echo ${GITHUB_REF:10})
uses: elgohr/Publish-Docker-Github-Action@master
with:
name: myDocker/repository
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
tags: "latest,${{ env.RELEASE_VERSION }}"
tags: "latest,${{ env.STATE_RELEASE_VERSION }}"
```

#### tag_names
Expand Down

2 comments on commit e6b13fe

@Fgerthoffert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elgohr,

I updated a workflow to use the change you documented, but it seems that pre is not being recognized by GitHub Actions.

Screen Shot 2020-11-18 at 4 35 47 PM

I couldn't find it in the documentation for the step neither: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idsteps

Would you have an idea why ?

Thanks,

@Fgerthoffert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it to work using the following:

Screen Shot 2020-11-18 at 6 15 41 PM

Please sign in to comment.