Use the updated api-sdk version to allow querying of the API with eli…

…feAssessmentSignificance terms elifesciences/issues#9169
elifesciences · Feb 17, 2025 · da5503f · da5503f
1 parent 4735c96
commit da5503f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/Controller/BrowseController.php b/src/Controller/BrowseController.php
@@ -41,7 +41,7 @@ public function queryAction(Request $request) : Response
 
         $search = $this->get('elife.api_sdk.search.page')
             ->forSubject(...$arguments['query']['subjects'])
-            // ->forElifeAssessmentSignificance(...ElifeAssessmentTermsFilter::fromMinimumSignificance($arguments['query']['minimumSignificance']))
+            ->forElifeAssessmentSignificance(...ElifeAssessmentTermsFilter::fromMinimumSignificance($arguments['query']['minimumSignificance']))
             ->forType(...$apiTypes)
             ->sortBy('date');
 

diff --git a/test/Controller/BrowseControllerTest.php b/test/Controller/BrowseControllerTest.php
@@ -317,6 +317,7 @@ private function buildUrlRequestForOneItem()
             'per-page' => '1',
             'sort' => 'date',
             'order' => 'desc',
+            'elifeAssessmentSignificance[]' => ['important', 'fundamental', 'landmark', 'useful', 'valuable', 'not-assigned'],
             'type[]' => $this->researchTypes,
             'use-date' => 'default',
         ]);
@@ -330,6 +331,7 @@ private function buildUrlRequestForTenItems()
             'per-page' => '10',
             'sort' => 'date',
             'order' => 'desc',
+            'elifeAssessmentSignificance[]' => ['important', 'fundamental', 'landmark', 'useful', 'valuable', 'not-assigned'],
             'type[]' => $this->researchTypes,
             'use-date' => 'default',
         ]);