Closes eligrey/classList.js#50 #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested with IE8, IE9, Safari on iOS 6.1.3 (and all new browsers) |
|
Don't forget to change https://github.com/eligrey/classList.js/blob/master/classList.js#L3 Also, you're leaking a global ( |
|
Should be better now :) |
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| * classList.js: Cross-browser full element.classList implementation. | |||
| * 1.1.20150312 | |||
| * 1.1.20150404 | |||
There was a problem hiding this comment.
Still living in 2015 I see. Mind updating that to 2016?
| @@ -12,229 +12,244 @@ | |||
| /*! @source http://purl.eligrey.com/github/classList.js/blob/master/classList.js */ | |||
|
|
|||
| if ("document" in self) { | |||
| (function() { | |||
There was a problem hiding this comment.
The enclosure should probably enclose everything.
Suggest:
(function(self) {
'use strict';
if(!("document" in self)) {
return;
}
// try/catch
// ....
})(typeof self !== 'undefined' ? self : this);This would help reduce nesting instead of increase it.
Such an enclosure would also fix: #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.