crix-callgraph: fix a use-after-scope memory error in VirtualCallTargets.cpp #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::function_ref
stores a reference but does not own a callable object [1].LookupDomTree
of that type is assigned to a local lambda object inVirtualCallTargets::run()
and is used later inVirtualCallTargets::scanTypeTestUsers()
, but the local lambda object is already out of scope at that time, and crashes the program on my computer. This pull request changes the type ofLookupDomTree
tostd::function
, which owns a callable object.[1] LLVM reference
Signed-off-by: Binrui Dong [email protected]