Silence dialyzer warnings about do_plural_rule #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libraries that depend on Cldr might use the `:extra_returns` feature in dialyzer, which will warn if the typespec of a function specifies return types that are not part of the success typing. My understanding is that the behavior (and therefore success typing) of `do_plural_rule depends/8` on the locale used, so we cannot accurately tell what the correct return type is. Therefore, this commit posits to silence dialyzer warnings about `do_plural_rule/8`.
|
Ideally, we should use |
|
Sorry for the delay, much appreciated. I will be publishing a new release to hex soon to also ensure Elixir 1.16 there are no warnings. 🥳🥳🥳🥳🥳 |
kipcole9
added a commit
that referenced
this pull request
Nov 2, 2023
Silence dialyzer warnings about do_plural_rule
|
I've published ex_cldr version 2.37.5 with the following changelog entry: Bug Fixes
Thanks again! |
|
No, thank you for the great work you've put into the cldr-project! |
|
Thanks for the kind words Philip, I appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libraries that depend on Cldr might use the
:extra_returnsfeature in dialyzer, which will warn if the typespec of a function specifies return types that are not part of the success typing.My understanding is that the behavior (and therefore success typing) of
do_plural_rule depends/8on the locale used, so we cannot accurately tell what the correct return type is. Therefore, this commit posits to silence dialyzer warnings aboutdo_plural_rule/8.Fixes #219