Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for AWS credentials file #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

l1x
Copy link

@l1x l1x commented Oct 22, 2023

It is a good idea to use the credentials file instead of littering shell history or even code with AWS credentials. This is the initial version of support .aws/credentials file.

https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html#cli-configure-files-format

  • Initial support for credentials
  • Supporting profiles
  • SSO support

@l1x
Copy link
Author

l1x commented Oct 30, 2023

@josevalim do you see any value in this? What is the current state of play with AWS libraries in Elixir?

Just to give you more context:

Using AWS profiles that load credentials from the credentials files offers several advantages over using access key and secret key in code:

  • Security: Storing credentials in a separate file provides a layer of security. The credentials file can be restricted to specific users or processes, reducing the risk of unauthorized access.

  • Flexibility: Credentials files allow for easy switching between different AWS accounts or roles. Developers or administrators can switch profiles without modifying the application code. This is especially useful when managing multiple environments (development, testing, production) or AWS accounts.

What do you think?

@josevalim
Copy link
Member

Should we support this through aws_credentials instead? https://github.com/aws-beam/aws_credentials

I am fine with improving the integration with AWS but it should probably not be part of this library, as it is just the specification. Instead we should add this to Explorer, Livebook, etc. :)

@l1x
Copy link
Author

l1x commented Nov 14, 2023

Should we support this through aws_credentials instead? https://github.com/aws-beam/aws_credentials

I am fine with improving the integration with AWS but it should probably not be part of this library, as it is just the specification. Instead we should add this to Explorer, Livebook, etc. :)

Sure thing! Let me have a look into that.

@josevalim
Copy link
Member

Actually, now that I think about it, we can make aws_credentials an optional dependency and add config_from_credentials, which will raise if aws_credentials is not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants