Mechanical refactor of Descr, avoid intermediate lists #14230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jan 27, 2025
lib/elixir/lib/module/types/descr.ex
Outdated
| @@ -2970,4 +2968,8 @@ defmodule Module.Types.Descr do | |||
| end | |||
|
|
|||
| defp iterator_non_disjoint_intersection?(:none, _map), do: false | |||
|
|
|||
| defp map_or([head | tail], fun) do | |||
There was a problem hiding this comment.
Suggested change
| defp map_or([head | tail], fun) do | |
| defp non_empty_map_or([head | tail], fun) do |
josevalim
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple of places where we were building intermediate lists which could be done in a single pass.