Refactor Descr.map_all_but_one #14231
Merged
+14
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another mechanical refactor.
Comparing map keys by casting them into sets is much slower and memory intensive than checking map size + loop over the keys (bench).
Also using
Enum.count_until
to bail at the second different key found.We could probably avoid the extra
Enum.find
pass by re-using the pattern from map fusion, but we can't reuse the exact same code because we're not checking for subtypes here (well, perhaps we could actually leverage this information and do something smart?)Finally, removed the
?
from the name since it doesn't return a bool.