Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ex_unit diff bug #14275

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

dkuku
Copy link
Contributor

@dkuku dkuku commented Feb 17, 2025

I found the reason of #14268
we passed the length of left list and then the code looked like this:

left = [:b, :c]
right = [:a, :b, :c]
{parsed_right = [:a, :b], improper_right = [:c]} = split_right_list(right, length(left), [])

I added one test, and fixed two one, which looks like it's invalid currently.
There are still two failing tests - I may need a hand with this.

@dkuku
Copy link
Contributor Author

dkuku commented Feb 18, 2025

It's ready

@dkuku dkuku marked this pull request as ready for review February 18, 2025 16:41
@josevalim josevalim merged commit c65f955 into elixir-lang:main Feb 19, 2025
10 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@josevalim josevalim mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants