Added batching to regression metrics #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Sep 4, 2024
|
Yes, that's exactly what I meant. Originally, I added option |
msluszniak
changed the title
|
Sounds good, I’ll go with your suggestion! |
josevalim
approved these changes
Sep 11, 2024
msluszniak
approved these changes
Sep 11, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #144 issue:
I've added batching to the
Regressionmetrics, similar to the batching implemented in theDistancesmetrics. However, I'm not entirely sure if I fully understood the issue, so I would greatly appreciate any feedback.I did not make changes to the following metrics:
mean_pinball_lossd2_absolute_error_scored2_pinball_scoreThese metrics appear to already support batching through the
:multioutputargument. If that's the case, perhaps we should consider standardizing the argument to:axesfor consistency across similar functions.Please let me know if I’m mistaken about anything.