-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_sender_codec #190
base: master
Are you sure you want to change the base?
Add set_sender_codec #190
Conversation
c75491a
to
2af9b7f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 84.75% 84.88% +0.13%
==========================================
Files 49 49
Lines 2512 2554 +42
==========================================
+ Hits 2129 2168 +39
- Misses 383 386 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
cd540df
to
a4f6fae
Compare
a4f6fae
to
f5a0198
Compare
report_recorder = %ReportRecorder{ | ||
sender.report_recorder | ||
| clock_rate: codec && codec.clock_rate | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clock rate of ReportRecorder shouldn't change as it may result in incorrect RTCP reports. Instead, we probably should generate a new ssrc and start sending new RTCP reports. Anyways, we don't allow for codec change that has different clock rate so we can safely delete this code
695b33e
to
b36e75d
Compare
536e60a
to
9b8b624
Compare
9b8b624
to
61e3a04
Compare
This PR allows to set codec that should be used for sending with the following remarks:
set_sender_codec
must use a codec with the same clock rate. This is because using a new clock rate requires a new SSRC. Also, ReportRecorder, which generates RTCP reports relies on clock rate so changing it after we started sending packets could result in incorrect reportsset_sender_codec
with a new codec that is supportedIt also:
RFC considerations: