-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change data storage to files #461
base: master
Are you sure you want to change the base?
Conversation
@vbrazo So, I wondered if we could move the data passed in the functions to a file, which would improve the reading of the modules. I would be down to change everything if it gets accepted 👍. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide benchmarks to show if this approach is faster than the current one?
I'd also like to get an opinion from @igas or @anthonator on this PR.
So, I made some changes after running the benchmark as I found out that my solution was a bit slower. After my optimization, this was the result. What do you think @vbrazo ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laraujo7 thanks for adding the benchmark.
e604590
to
2a9a44e
Compare
d7214bb
to
24d0b82
Compare
This would make contributing to Faker much easier! 🙏 |
I've added: