Make tests compatible with Elixir 1.16 and 1.17

.github/workflows/ci.yaml

@@ -112,8 +112,21 @@ jobs:
           - elixir: 1.15.x
             otp: 25.x
             os: ubuntu-20.04
-          # Something changed in otp 26 for seed and single test started producing failures
-          # it does not affect functionality, only CI
-          # - elixir: 1.15.x
-          #   otp: 26.x
-          #   os: ubuntu-20.04
+          - elixir: 1.16.x
+            otp: 24.x
+            os: ubuntu-20.04
+          - elixir: 1.16.x
+            otp: 25.x
+            os: ubuntu-20.04
+          - elixir: 1.16.x
+            otp: 26.x
+            os: ubuntu-20.04
+          - elixir: 1.17.x
+            otp: 25.x
+            os: ubuntu-22.04
+          - elixir: 1.17.x
+            otp: 26.x
+            os: ubuntu-22.04
+          - elixir: 1.17.x
+            otp: 27.x
+            os: ubuntu-22.04

CHANGELOG.md

@@ -10,6 +10,9 @@ Change log itself follows [Keep a CHANGELOG](http://keepachangelog.com) format.
 
 ### Added
 
+- Test with Elixir 1.16 and 1.17 on CI [[@ypconstante](https://github.com/ypconstante)]
+- Test with OTP 26 and 27 on CI [[@ypconstante](https://github.com/ypconstante)]
+
 ### Changed
 
 ### Deprecated
@@ -19,6 +22,7 @@ Change log itself follows [Keep a CHANGELOG](http://keepachangelog.com) format.
 ### Fixed
 
 - Fix compile and runtime warnings on Elixir 1.17 [[@ypconstante](https://github.com/ypconstante)]
+- `Faker.Internet.slug` and `Faker.Markdown.markdown/0` results won't change between Elixir versions [[@ypconstante](https://github.com/ypconstante)]
 
 ### Security
 

lib/faker/file.ex

@@ -30,8 +30,8 @@ defmodule Faker.File do
       ~w(video/mpeg video/mp4 video/ogg video/quicktime video/webm video/x-matroska video/x-ms-wmv video/x-flv)
   }
 
-  @categories_extensions Map.keys(@extensions)
-  @categories_mimes Map.keys(@mimes)
+  @categories_extensions @extensions |> Map.keys() |> Enum.sort()
+  @categories_mimes @mimes |> Map.keys() |> Enum.sort()
 
   @doc """
   Returns a random file extension

lib/faker/internet.ex

@@ -4,7 +4,7 @@ defmodule Faker.Internet do
   alias Faker.Util
 
   import Faker.Util, only: [pick: 1]
-  import Faker, only: [localize: 1]
+  import Faker, only: [localize: 1, random_uniform: 0]
 
   @moduledoc """
   Functions for generating internet related data
@@ -292,11 +292,11 @@ defmodule Faker.Internet do
   ## Examples
 
       iex> Faker.Internet.slug()
-      "sint-deleniti-consequatur-ut"
+      "deleniti-sint-consequatur-ut"
       iex> Faker.Internet.slug()
-      "sit_et"
+      "cumque_sit_aut_expedita"
       iex> Faker.Internet.slug(["foo", "bar"])
-      "foo-bar"
+      "foo_bar"
       iex> Faker.Internet.slug(["foo", "bar"], ["."])
       "foo.bar"
   """
@@ -313,7 +313,7 @@ defmodule Faker.Internet do
   @spec slug([String.t()], [String.t()]) :: String.t()
   def slug(words, glue) do
     words
-    |> Enum.take_random(length(words))
+    |> Enum.sort_by(fn _ -> random_uniform() end)
     |> Enum.join(pick(glue))
     |> String.downcase()
   end

lib/faker/markdown.ex

@@ -1,5 +1,5 @@
 defmodule Faker.Markdown do
-  import Faker, only: [random_between: 2]
+  import Faker, only: [random_between: 2, random_uniform: 0]
 
   alias Faker.Lorem
   alias Faker.Util
@@ -191,13 +191,13 @@ defmodule Faker.Markdown do
   ## Examples
 
       iex> Faker.Markdown.markdown()
-      "cumque | est | necessitatibus\\n---- | ---- | ----\\nbeatae | ex | sunt\\nsoluta | possimus | soluta\\nasperiores | qui | vitae\\n\\n* Et vitae vitae ut quisquam corporis quisquam ab harum ipsa.\\n* Numquam maxime ut aut inventore eius rerum beatae.\\n* Qui officia vel quaerat expedita.\\n* Perspiciatis rerum nam repellendus inventore nihil.\\n\\n`Sequi ducimus qui voluptates magni quisquam sed odio.`\\n\\n```elixir\\nError non impedit tempora minus voluptatem qui fugit.\\n```\\n\\n### Cupiditate"
+      "## Aut\\n\\n```ruby\\nBeatae ex sunt soluta possimus soluta asperiores qui vitae animi.\\n```\\n\\n`Et vitae vitae ut quisquam corporis quisquam ab harum ipsa.`\\n\\n* Maxime ut aut inventore eius rerum beatae?\\n* Qui officia vel quaerat expedita.\\n* Perspiciatis rerum nam repellendus inventore nihil.\\n* Sequi ducimus qui voluptates magni quisquam sed odio.\\n* Vel error non impedit tempora minus.\\n\\nfugit | cupiditate | fuga | ab\\n---- | ---- | ---- | ----\\nconsectetur | harum | earum | possimus\\ntotam | nobis | provident | quisquam\\nmodi | accusantium | eligendi | numquam"
       iex> Faker.Markdown.markdown()
-      "_Illo_ voluptas quod blanditiis est non id quibusdam qui omnis. Odit dicta dolores at ut delectus magni atque eos? Labore voluptate laudantium qui.\\n\\n### Voluptatibus\\n\\nullam | similique | minima | laudantium\\n---- | ---- | ---- | ----\\nvoluptate | reiciendis | repellat | et\\npraesentium | quia | sed | nemo\\nminus | ea | vero | repellat\\ncumque | nihil | similique | repudiandae\\ncorrupti | rerum | sed | similique\\naccusamus | suscipit | perspiciatis | cum"
+      "Odit dicta dolores at ut delectus magni atque eos? Labore voluptate laudantium ~qui.~ Voluptatibus sed et enim ullam?\\n\\n1. Repellat et praesentium quia sed nemo minus ea!\\n2. Cumque nihil similique repudiandae corrupti!\\n3. Similique accusamus suscipit perspiciatis cum.\\n4. Dolore et ut earum possimus eos reprehenderit cupiditate omnis et.\\n5. Sit delectus possimus quo et est culpa eum ex?\\n6. Aut aut aut quisquam?\\n7. Tenetur alias est provident esse dicta ea illo consequatur maiores?"
       iex> Faker.Markdown.markdown()
-      "```erlang\\nSit delectus possimus quo et est culpa eum ex?\\n```\\n\\n1. Aut aut quisquam labore fuga tenetur alias.\\n2. Esse dicta ea illo consequatur!\\n3. Et quia culpa sunt sit eius cumque porro ut eum.\\n4. Id maxime dolorum animi!\\n5. Deserunt ipsa consequuntur eveniet asperiores.\\n6. Quia numquam voluptas vitae repellat tempore.\\n7. Harum voluptas harum modi omnis quam dolor a aliquam officiis?\\n8. Neque voluptas consequatur sed cupiditate dolorum pariatur et.\\n9. Aut voluptatem natus amet eius eos non dolorum.\\n\\n`Pariatur ex illo aliquam rerum ab voluptatem exercitationem nobis enim.`\\n\\nCorporis **unde** ex enim dolore ut consequuntur eaque! Eius totam nobis est."
+      "* Porro est id maxime dolorum animi.\\n* Deserunt ipsa consequuntur eveniet asperiores.\\n* Quia numquam voluptas vitae repellat tempore.\\n* Harum voluptas harum modi omnis quam dolor a aliquam officiis?\\n* Neque voluptas consequatur sed cupiditate dolorum pariatur et.\\n* Aut voluptatem natus amet eius eos non dolorum.\\n* Pariatur ex illo aliquam rerum ab voluptatem exercitationem nobis enim.\\n* Eos corporis unde ex enim dolore ut consequuntur.\\n* Dicta eius totam nobis est a eveniet ab magni.\\n* Consequatur unde dolorem et nihil laudantium ea veniam necessitatibus."
       iex> Faker.Markdown.markdown()
-      "Qui iusto quisquam minus ad omnis quaerat quidem _impedit!_ Qui id ut repellat qui repudiandae quia cumque excepturi laudantium.\\n\\n`Non consequatur molestiae laboriosam sit!`\\n\\n## Aperiam"
+      "1. Repellat qui repudiandae quia cumque excepturi laudantium accusantium!\\n2. Sunt non consequatur molestiae laboriosam sit aperiam.\\n3. Voluptatem est beatae delectus minus qui molestiae dolorem aut.\\n4. Iure enim sapiente quia voluptas esse!\\n\\n```go\\nVoluptas ullam ratione et esse optio qui ut sed dignissimos!\\n```\\n\\nsaepe | a | illo\\n---- | ---- | ----\\nut | eos | aliquid\\nquisquam | omnis | magni\\nconsequuntur | molestiae | expedita\\n\\n* Ducimus est nulla repellat reiciendis est est veritatis.\\n* Quaerat assumenda ut reiciendis eaque in!\\n* Aliquam quis sapiente facere?\\n* Nihil suscipit pariatur qui."
   """
   @spec markdown() :: String.t()
   def markdown do
@@ -213,7 +213,7 @@ defmodule Faker.Markdown do
     |> Enum.filter(fn _ ->
       Util.pick([true, false])
     end)
-    |> Enum.shuffle()
+    |> Enum.sort_by(fn _ -> random_uniform() end)
     |> Stream.map(fn fun ->
       apply(__MODULE__, fun, [])
     end)

lib/faker/phone/en_gb.ex

@@ -31,13 +31,13 @@ defmodule Faker.Phone.EnGb do
   ## Examples
 
       iex> Faker.Phone.EnGb.number()
-      "+44054264610"
+      "+44042646108"
       iex> Faker.Phone.EnGb.number()
-      "+44562970523"
+      "07897 052357"
       iex> Faker.Phone.EnGb.number()
-      "+447502 030320"
+      "+44803032097"
       iex> Faker.Phone.EnGb.number()
-      "+447933 760337"
+      "+447776 033745"
   """
   @spec number() :: String.t()
   def number do
@@ -54,13 +54,13 @@ defmodule Faker.Phone.EnGb do
   ## Examples
 
       iex> Faker.Phone.EnGb.landline_number()
-      "+44331542646"
+      "+44335426461"
       iex> Faker.Phone.EnGb.landline_number()
-      "+44560832970"
+      "+44343297052"
       iex> Faker.Phone.EnGb.landline_number()
-      "+44023570203"
+      "+44567020303"
       iex> Faker.Phone.EnGb.landline_number()
-      "+44703209733"
+      "+44709733760"
   """
   @spec landline_number() :: String.t()
   def landline_number do

lib/faker/random/test.ex

@@ -3,13 +3,13 @@ defmodule Faker.Random.Test do
 
   def random_between(left, right) do
     set_seed(:ets.lookup(:seed_registry, self()))
-    Enum.random(left..right)
+    left + :rand.uniform(right - left + 1) - 1
   end
 
   def random_bytes(total) do
     set_seed(:ets.lookup(:seed_registry, self()))
 
-    Stream.repeatedly(fn -> Enum.random(0..255) end)
+    Stream.repeatedly(fn -> random_between(0, 255) end)
     |> Enum.take(total)
     |> IO.iodata_to_binary()
   end

lib/faker/vehicle.ex

@@ -248,13 +248,13 @@ defmodule Faker.Vehicle do
 
   ## Examples
       iex> Faker.Vehicle.vin()
-      "1C68203VCV0360337"
+      "1C689K5Y000T03374"
       iex> Faker.Vehicle.vin()
-      "5190V7FL8YX113016"
+      "D0B19RGCD90H16449"
       iex> Faker.Vehicle.vin()
-      "4RSE9035H9JA97940"
+      "RSE90354760B00530"
       iex> Faker.Vehicle.vin()
-      "59E4A13G890C97377"
+      "L9Z63TST830A76983"
   """
   def vin do
     Util.format("%10x%y%x%5d",