Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Koloxarto/fix ragknowledge for postgres #2153

Conversation

web3gh
Copy link
Contributor

@web3gh web3gh commented Jan 11, 2025

Relates to

#1620

Risks

Medium. Bugfixing on an experimental feature but touching postgres adapter

Background

What does this PR do?

Fix an issue on the new ragKnowledge feature when using postgres

What kind of change is this?

Bug fix

Why are we doing this? Any context or related work?

So the feature is usable :)

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Try to use ragKnowledge feature in the knowledge section of the character file with postgres. before this PR there were uuid errors.

Where should a reviewer start?

Detailed testing steps

Discord username

koloxarto

@web3gh web3gh marked this pull request as draft January 11, 2025 14:33
@web3gh web3gh force-pushed the koloxarto/fix_ragknowledge_when_combining_files_and_strings branch from 819861a to 4bf2465 Compare January 11, 2025 17:40
@web3gh web3gh force-pushed the koloxarto/fix_ragknowledge_when_combining_files_and_strings branch from 4bf2465 to 9e859b8 Compare January 11, 2025 17:40
@web3gh web3gh changed the title Koloxarto/fix ragknowledge when combining files and strings Koloxarto/fix ragknowledge for postgres Jan 11, 2025
@web3gh web3gh marked this pull request as ready for review January 11, 2025 17:46
@odilitime odilitime changed the title Koloxarto/fix ragknowledge for postgres fix: Koloxarto/fix ragknowledge for postgres Jan 12, 2025
@odilitime odilitime merged commit 6690ea6 into elizaOS:develop Jan 12, 2025
6 checks passed
mgunnin added a commit to mgunnin/kairos that referenced this pull request Jan 12, 2025
* main: (704 commits)
  bump version (elizaOS#2193)
  feat(security): Implement comprehensive file upload security measures - Add FileSecurityValidator, file type restrictions, size limits, path traversal prevention, enhanced logging and security documentation (elizaOS#1753) (elizaOS#1806)
  fix(client-twitter): clean up mention deduplication (elizaOS#2185)
  fix postgres adapter migration extension creation which already exists at this point (elizaOS#2188)
  Update types.ts
  fix json format typo
  fix quai deps
  fix path
  Add Persian README File
  chore: lint and fix pass on develop (elizaOS#2180)
  bump version to 0,1,8
  bump
  clean up unused var in catch
  comment out unused AkashMessage interface
  bump eslint so it doesn't crash
  remove duplicate TOGETHER in case, lint/unused var
  convert imageDescriptionsArray from let to const per lint
  fix: Koloxarto/fix ragknowledge for postgres (elizaOS#2153)
  fix: fix the chat stuck in infinite loop (elizaOS#1755)
  fix: remove problematic redundant uuid conversion and add api input param validations to api server (elizaOS#2051)
  ...
0xpi-ai pushed a commit to 0xpi-ai/NayariAI that referenced this pull request Jan 15, 2025
* fix formatting out of the way

* fix postgress chunk uuid handling for ragKnowledge

---------

Co-authored-by: Odilitime <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants