Skip to content

Commit

Permalink
docs minor fix
Browse files Browse the repository at this point in the history
  • Loading branch information
elliot-100 committed Nov 28, 2023
1 parent 528c554 commit 9b7c343
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Historic and pre-release versions aren't necessarily included.
- `get_public_club_info()`: raise exception on redirect; basic unit tests
- `get_private_member_counts()` basic unit tests

## Fixed
### Fixed

- Duplicate logging message

Expand Down
4 changes: 0 additions & 4 deletions britishcycling_clubs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,6 @@ def _get_club_name_from_profile(soup: BeautifulSoup) -> str:
def _get_total_members_from_profile(soup: BeautifulSoup) -> int:
"""Return the club's total members count from profile page soup."""
about_div = soup.find("div", id="about")

# TypeError is raised if page other than a club profile page is returned
# e.g. club_id is incorrect; club's profile is offline pending reaffiliation
# Consider checking URL returned as a more explicit check
if not isinstance(about_div, Tag):
raise TypeError

Expand Down

0 comments on commit 9b7c343

Please sign in to comment.