Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to beatsaver 3d viewer (fixes #43) #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ngokevin
Copy link
Contributor

No description provided.

Copy link
Collaborator

@luludotdev luludotdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the layout of buttons needs to be tweaked, there are already too many.

I think @elliotttate was working on a mock-up.

@ngokevin
Copy link
Contributor Author

Is the mockup a complete redesign or just compacting the button list? If you want, maybe our artist / designer could also offer a mockup.

@luludotdev
Copy link
Collaborator

I wouldn't say no to more mockups, having options would be great.
I have no idea what the other mockup was.

@ngokevin
Copy link
Contributor Author

@elliotttate What mockups did you have or were working on? Just to get an idea of how to handle the buttons and links.

@ngokevin
Copy link
Contributor Author

ngokevin commented Feb 5, 2019

We could temporarily replace the audio preview with a button that opens a tab to the Viewer which seems to be useful for previewing maps. Would also support audio seeking, direct linking, iOS (soon), and if different difficulties had different songs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants