Default to passing --warn to Elm #32
Conversation
Following the change to node-elm-compiler.
|
Closed as per my comment #31 (comment) |
| @@ -8,7 +8,8 @@ var cachedDependencies = []; | |||
|
|
|||
| var defaultOptions = { | |||
| cache: false, | |||
| yes: true | |||
| yes: true, | |||
| warn: true | |||
There was a problem hiding this comment.
Can we default this to false instead?
There was a problem hiding this comment.
As you wish. I don’t know what people prefer, but I haven’t seen any unhelpful warnings from Elm so far. My personal preference is to see the warnings, in order to copy top-level type declarations into my source code.
There was a problem hiding this comment.
I actually dig this idea. It's easy to turn off if you don't like them, and culturally it seems nice to encourage people to clean things up.
@eeue56 any objection to trying it this way and changing it if it's annoying in practice?
There was a problem hiding this comment.
As @eeue56 pointed out to me, elm-lang/elm-make#27 means turning on warn by default won't give you all the warnings every time, only when files change and recompile...that seems like it would be surprising behavior, so I'd say let's revisit this default if the status elm-lang/elm-make#27 changes.
|
I think we'll handle this in #33 since it comes with the node upgrade too. Thanks all the same! |
Fixes #31.