Fix in-browser compiler error display #2247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supermario
added a commit
to lamdera/compiler
that referenced
this pull request
Mar 16, 2022
|
Thanks for suggesting these code changes. To set expectations:
Finally, please be patient with the core team. They are trying their best with limited resources. |
lydell
reviewed
Mar 16, 2022
| @@ -57,6 +57,9 @@ viewError error = | |||
| , style "white-space" "pre-wrap" | |||
| , style "background-color" "black" | |||
| , style "padding" "2em" | |||
| , style "box-sizing" "border-box" | |||
| , style "width" "100%" | |||
| , style "overflow" "scroll" | |||
There was a problem hiding this comment.
Should this use "auto" so there’s no unnecessary scrollbar when there is no overflow?
The default on macOS is to draw scrollbars on top of content, and only show it when scrolling. By changing a system setting, you can make macOS behave like Windows and Linux, which is to let the scrollbars take space and always be visible.
The difference between scroll and auto is that if no scrolling is needed, scroll shows ugly disabled scrollbars while auto shows no scrollbars at all.
|
Confirmed working in lamdera-next build offered by @supermario |
supermario
added a commit
to lamdera/compiler
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Summary: Fix: Error display breaks on long text - the left and right part of the source code is clipped.
SSCCE
It looks like this and I can only scroll to the right:
