Make Char.isLower and Char.isUpper Unicode-aware (2nd try) #1138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people with non-ASCII alphabets work with
Char.isLower
andChar.isUpper
. UsestoUpper
andtoLower
underneath, which use Javascript'sString.prototype.toLower/UpperCase()
.The second condition in the functions is there to distinguish between characters that have an upper/lower-case pairing, and those that don't (
'0' == Char.toLower '0'
but we don't wantisLower '0'
to be true).